Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Fix gitpod meson version #55331

Closed
wants to merge 12 commits into from
Closed

Conversation

theuerc
Copy link
Contributor

@theuerc theuerc commented Sep 30, 2023

The issue is that meson is out of date in gitpod.

pip install --upgrade meson

The above command fixes the issue, so I added it to the build instructions in gitpod.yml. It could be added to the dockerfile instead, but I decided to be cautious.

I added the update command to both the init and command sections because gitpod sometimes skips the init section and goes straight to the command section without installing anything.

With the fix:

gitpod@theuerc-pandas-jy3jlfp1dg6:/workspace/pandas$ python
Python 3.10.8 (main, Dec  6 2022, 14:13:21) [GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pandas
+ /usr/local/bin/ninja
[1/1] Generating write_version_file with a custom command
>>> pandas.to_datetime("2022-01-01")
Timestamp('2022-01-01 00:00:00')
>>> 

I'm running the tests in gitpod overnight and I'll check the log file in the morning.

Update:

These are the results:

661 failed, 211445 passed, 7990 skipped, 2426 xfailed, 15 xpassed, 405 warnings, 58 errors in 4524.22s (1:15:24)

The failed tests are the ones that interact with either S3 or a nonexistent SQL server, so I think everything works.

@theuerc theuerc changed the title Fix gitpod meson version BLD: Fix gitpod meson version Sep 30, 2023
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used Gitpod, and I fail to see why it's being more cautious adding it here than in the Dockerfile, but this seems reasonable to me, happy to get it merged.

@datapythonista datapythonista added the Admin Administrative tasks related to the pandas project label Oct 7, 2023
@theuerc
Copy link
Contributor Author

theuerc commented Oct 17, 2023

I'll update it every so often until someone with write access comes along again.

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 26, 2023
@mroeschke
Copy link
Member

Thanks for the PR, but this is currently getting overhauled in #56375 which should also solve your original issue so closing in favor of that PR

@mroeschke mroeschke closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Administrative tasks related to the pandas project Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUILD: pandas build failing on Gitpod due to Meson
3 participants